Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit stream events in stream_connection.ts #530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CJxD
Copy link

@CJxD CJxD commented Nov 25, 2024

When using the managedwriter, I found that the connection often needs to reconnect, but my calling code was unable to determine when this happens.

In this commit I have forwarded the various events from the underlying connection, except 'close' is only called when the stream_connection has been instructed to close, and a new event 'reconnect' is emitted when the stream has been closed and reopened.

Fixes #529 🦕

@CJxD CJxD requested review from a team as code owners November 25, 2024 15:24
@CJxD CJxD requested a review from Linchin November 25, 2024 15:24
Copy link

google-cla bot commented Nov 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Nov 25, 2024
* feat: emit stream events in stream_connection.ts (googleapis#529)
@CJxD
Copy link
Author

CJxD commented Nov 25, 2024

I'm having some difficulty with the Google CLA - I have signed it on behalf of the organisation and added the members to our group [email protected] but it doesn't seem to be picking it up.

It might be worth closing this PR and making the changes yourself. I will continue with my workaround for now.

@alvarowolfx alvarowolfx requested review from alvarowolfx and removed request for Linchin November 25, 2024 18:22
@alvarowolfx
Copy link
Contributor

thanks for the PR @CJxD, I'll take over from here and try to add those improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit close/reconnect events on StreamConnections
2 participants