feat: add support for missing value interpretation #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shollyman
reviewed
Mar 15, 2024
| const protoDescriptor: DescriptorProto = | ||
| adapt.convertStorageSchemaToProto2Descriptor(storageSchema, 'root'); | ||
|
|
||
| // Row 1 |
There was a problem hiding this comment.
These sample rows are confusing, as the row data isn't compatible with the updatedSchema above. If you're wanting empty rows that's fine, just describe what you're doing so the interaction is clearer.
There was a problem hiding this comment.
I've pushed some updates to the test to make the full schema more explicit. The idea here is to send rows with some empty values and show that they are being filled or not accordingly to the MVI settings.
alvarowolfx
changed the title
Both |
product-auto-label
bot
added
size: l
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
approved these changes
Mar 20, 2024
src/managedwriter/json_writer.ts
Outdated
| @@ -88,6 +87,30 @@ export class JSONWriter { | |||
| this._encoder.setProtoDescriptor(protoDescriptor); | |||
| } | |||
|
|
|||
| /** | |||
| * Update how missing values are interpreted by for the given stream. | |||
src/managedwriter/writer.ts
Outdated
| protoDescriptor: IDescriptorProto; | ||
|
|
||
| /** | ||
| * Controls how missing values are interpreted by for a given stream. |
src/managedwriter/writer.ts
Outdated
| @@ -72,6 +126,28 @@ export class Writer { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Update how missing values are interpreted by for the given stream. | |||
shollyman
approved these changes
Mar 21, 2024
src/managedwriter/writer.ts
Outdated
|
|
||
| /** | ||
| * Controls how missing values are interpreted by for a given stream. | ||
| * `missingValueInterpretations` set for individual colums can override the default chosen |
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
alvarowolfx
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426 🦕