-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to pyproject.toml #2041
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your assistance with converting this to pyproject.toml. I am curious... you went through and offered up conversion PRs for a large number of google projects. What inspired this? |
@chalmerlowe For me, it was more about how to motivate/inspire the project maintainers to migrate to pyproject.toml, because this kind of problem (build systems) can only be solved in coordination with other projects, as they tend to rely on the common internal practices, standards and tooling. I use these libraries at work and want them to keep up with the latest Python standards and trends (including typing). pyproject.toml is a good first step towards modernising these Python projects, I believe. |
That makes sense.
and will be migrating all of these to pyproject.toml in the near future. |
Tracking issue googleapis/google-cloud-python#13171
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕