Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to pyproject.toml #2041

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Conversation

rinarakaki
Copy link
Contributor

@rinarakaki rinarakaki commented Oct 15, 2024

Tracking issue googleapis/google-cloud-python#13171

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested review from a team as code owners October 15, 2024 12:09
@rinarakaki rinarakaki requested a review from hongalex October 15, 2024 12:09
Copy link

conventional-commit-lint-gcf bot commented Oct 15, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 15, 2024
@mrfaizal mrfaizal assigned chalmerlowe and unassigned whuffman36 Oct 21, 2024
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@chalmerlowe chalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
pyproject.toml Outdated Show resolved Hide resolved
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 13, 2024
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 1061611 into googleapis:main Nov 13, 2024
18 checks passed
@chalmerlowe
Copy link
Collaborator

@rinarakaki

Thank you for your assistance with converting this to pyproject.toml.

I am curious... you went through and offered up conversion PRs for a large number of google projects. What inspired this?

@rinarakaki rinarakaki deleted the pyproject branch November 13, 2024 14:53
@rinarakaki
Copy link
Contributor Author

@chalmerlowe
Thanks for reviewing this PR!

For me, it was more about how to motivate/inspire the project maintainers to migrate to pyproject.toml, because this kind of problem (build systems) can only be solved in coordination with other projects, as they tend to rely on the common internal practices, standards and tooling. I use these libraries at work and want them to keep up with the latest Python standards and trends (including typing). pyproject.toml is a good first step towards modernising these Python projects, I believe.

@chalmerlowe
Copy link
Collaborator

@rinarakaki

That makes sense.
I manage:

  • python-bigquery
  • python-bigquery-pandas
  • python-bigquery-sqlalchemy
  • python-bigquery-storage
  • python-db-dtypes-pandas

and will be migrating all of these to pyproject.toml in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants