Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make initial modack asynchronous #1127

Open
kamalaboulhosn opened this issue Mar 18, 2024 · 0 comments
Open

Make initial modack asynchronous #1127

kamalaboulhosn opened this issue Mar 18, 2024 · 0 comments
Assignees
@mukund-ananthu
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kamalaboulhosn
Copy link
Contributor

See this bug in the issue tracker for context. The initial modack is initiated synchronously upon receiving a message. In contrast, Java queues them to happen asynchronously. This appears to have some performance implications. We should instead queue these up to happen asynchronously, though we need to ensure we execute them relatively soon. Right now, they could happen as late as 90% of the ack deadline.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 18, 2024
@kamalaboulhosn kamalaboulhosn added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamalaboulhosn @mukund-ananthu