Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version.py missing from source on PyPI #337

Open
xylar opened this issue Aug 14, 2023 · 0 comments · May be fixed by #375
Open

version.py missing from source on PyPI #337

xylar opened this issue Aug 14, 2023 · 0 comments · May be fixed by #375
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@xylar
Copy link

xylar commented Aug 14, 2023

I'm trying to build sqlalchemy-spanner on conda-forge from the source from PyPI. In our CI, I'm seeing:

Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "/home/conda/feedstock_root/build_artifacts/sqlalchemy-spanner_1692018227156/work/setup.py", line 39, in <module>
      with open(VERSION_FILENAME) as f:
           ^^^^^^^^^^^^^^^^^^^^^^
  FileNotFoundError: [Errno 2] No such file or directory: '/home/conda/feedstock_root/build_artifacts/sqlalchemy-spanner_1692018227156/work/version.py'
  error: subprocess-exited-with-error

I'm seeing this for 1.2.0 but I checked the source for 1.6.2 on PyPI and version.py appears still to be missing.

A solution for us is to build from source from GitHub but this is less convenient. It would be nice to have version.py included with the source on PyPI as well.

@xylar xylar added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 14, 2023
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant