fix: support virtual_hosted_style and bucket_bound_hostname in v2 signing #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
gcf-owl-bot
bot
removed
the
owlbot:run
|
As discussed, looks good, but before we merge and release let's take a look at what upcoming work in this code area will look like. |
cojenco
added
the
do not merge
|
Closing as obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud Storage recommends using V4 over V2 signing. Moreover,
virtual_hosted_styleandbucket_bound_hostnamewere intended to work primarily for v4 signing.The main caveat being that v2 signing requires the resource path to include the bucket-name. This patch handles the special cases (non path-styles) for v2 signing
Fixes #1031 🦕