Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing mypy #318

Open
jaketf opened this issue Nov 17, 2020 · 0 comments
Open

Add typing mypy #318

jaketf opened this issue Nov 17, 2020 · 0 comments
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jaketf
Copy link

jaketf commented Nov 17, 2020

Is your feature request related to a problem? Please describe.
I'd like to catch common issues w/ mypy CI.
For example lookup_bucket("foo").blob("bar") mypy static analysis could tell us "lookup_bucket is Optional[storage.Blob] and NoneType has no method blob"
This can avoid code review comments like this: GoogleCloudPlatform/bigquery-utils#190 (comment)
Describe the solution you'd like
Please add typing so common issues can get caught w/ mypy in CI
Describe alternatives you've considered
Alternatively, each user of this library wanting this feature can implement a mypy stub but this would be better to maintain in the centralized codebase for google-cloud-storage https://mypy.readthedocs.io/en/stable/stubs.html

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 17, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Nov 18, 2020
@frankyn frankyn added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants