Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(snippet-bot): snippet-bot not detecting correct product prefix #3182

Closed
parthea opened this issue Feb 12, 2022 · 1 comment
Closed

bug(snippet-bot): snippet-bot not detecting correct product prefix #3182

parthea opened this issue Feb 12, 2022 · 1 comment
Assignees
@tmatsuo
Labels
bot: snippet-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 12, 2022

Snippet bot is reporting issues with regions tag in PR googleapis/python-datastream#66 however the product prefix datastream exists.

Here is an example of the output

You are about to add 92 region tags.
samples/generated_samples/datastream_generated_datastream_v1_datastream_create_connection_profile_async.py:26, tag datastream_generated_datastream_v1_Datastream_CreateConnectionProfile_async

The tag datastream_generated_datastream_v1_Datastream_CreateConnectionProfile_async appears to have the correct product prefix datastream.
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. bot: snippet-bot labels Feb 12, 2022
@parthea
Copy link
Contributor Author

parthea commented Feb 16, 2022 •
edited
Loading

This is WAI. snippet-bot is flagging that the product is not yet public.

@parthea parthea closed this as completed Feb 16, 2022
This was referenced Feb 25, 2022
Merged
Merged
Merged
Merged
@leahecole leahecole mentioned this issue Apr 6, 2022
Closed
This was referenced Apr 8, 2022
Merged
Merged
@bajajneha27 bajajneha27 mentioned this issue May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatsuo tmatsuo

Labels
bot: snippet-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmatsuo @parthea