Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showcase test: refactor and migrate client interceptors to TestClientInitializer #2743

Open
zhumin8 opened this issue May 7, 2024 · 0 comments · May be fixed by #3287
Open

showcase test: refactor and migrate client interceptors to TestClientInitializer #2743

zhumin8 opened this issue May 7, 2024 · 0 comments · May be fixed by #3287
Assignees
@ldetmer
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented May 7, 2024

context: #2737 (comment)

There are a couple of slightly different flavored client interceptors implemented for tests. e.g. ITApiVersionHeaders.java ITAutoPopulatedFields.java ITDynamicRoutingHeaders.java. We should try to migrate them into TestClientInitializer.
@zhumin8 zhumin8 added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 7, 2024
@zhumin8 zhumin8 mentioned this issue May 7, 2024
Merged
@lqiu96 lqiu96 mentioned this issue Sep 30, 2024
Merged
@ldetmer ldetmer self-assigned this Oct 2, 2024
@ldetmer ldetmer linked a pull request Oct 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldetmer ldetmer

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
2 participants
@ldetmer @zhumin8