Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translate anchors filter #514

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add translate anchors filter #514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afb06e4
Add translate anchors filter
simoncozens Jul 14, 2021
1637a0f
Sanity check before translating
simoncozens Jul 15, 2021
c3660cb
Use basefilter directly
simoncozens Jul 16, 2021
91688b0
Check for component use, fix sanity checks
simoncozens Jul 16, 2021
626701a
Downgrade warning to info
simoncozens Jul 16, 2021
cea39cb
Too stuff
simoncozens Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/ufo2ft/filters/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from .decomposeTransformedComponents import DecomposeTransformedComponentsFilter
from .explodeColorLayerGlyphs import ExplodeColorLayerGlyphsFilter
from .flattenComponents import FlattenComponentsFilter
from .optimizeAnchors import OptimizeAnchorsFilter
from .propagateAnchors import PropagateAnchorsFilter
from .removeOverlaps import RemoveOverlapsFilter
from .sortContours import SortContoursFilter
Expand All @@ -23,6 +24,7 @@
"DecomposeTransformedComponentsFilter",
"ExplodeColorLayerGlyphsFilter",
"FlattenComponentsFilter",
"OptimizeAnchorsFilter",
"PropagateAnchorsFilter",
"RemoveOverlapsFilter",
"SortContoursFilter",
Expand Down
27 changes: 27 additions & 0 deletions Lib/ufo2ft/filters/optimizeAnchors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
from ufo2ft.filters.transformations import TransformationsFilter
from fontTools.misc.transform import Identity, Transform
import logging

log = logging.getLogger(__name__)


class OptimizeAnchorsFilter(TransformationsFilter):
def set_context(self, font, glyphSet):
# Skip over transformations filter to base filter
return super(TransformationsFilter, self).set_context(font, glyphSet)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to explicitly call the BaseFilter.set_context(self, font, glyphSet) since that is what you are after.


def filter(self, glyph):
if len(glyph.anchors) == 0 or any(
not (a.name.startswith("_")) for a in glyph.anchors
):
# We're a base!
return False

# We are a mark glyph with (at least) one attachment point.
theanchor = glyph.anchors[0]
self.context.matrix = Identity.translate(-theanchor.x, -theanchor.y)
log.warn(
"Transforming glyph %s to zero anchor %s: %s"
% (glyph.name, theanchor.name, self.context.matrix)
)
return super().filter(glyph)