Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make zooming controls customizable #339

Closed
vladcioricagoogle opened this issue Jul 21, 2023 · 7 comments · Fixed by #457
Closed

Make zooming controls customizable #339

vladcioricagoogle opened this issue Jul 21, 2023 · 7 comments · Fixed by #457
Assignees
@vladcioricagoogle
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vladcioricagoogle
Copy link

Current zooming controls are not customizable at all and also they are not supporting dark mode.
@vladcioricagoogle vladcioricagoogle added triage me I really want to be triaged. type: question Request for information or clarification. Not an issue. labels Jul 21, 2023
@wangela
Copy link
Member

wangela commented Jul 21, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@vladcioricagoogle Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@wangela wangela added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: question Request for information or clarification. Not an issue. triage me I really want to be triaged. labels Aug 7, 2023
@wangela
Copy link
Member

wangela commented Aug 7, 2023

Once the pattern is established for the My Location button in #347 you can implement this for the zoom controls or other map controls as needed, @vladcioricagoogle.

@wangela wangela mentioned this issue Aug 10, 2023
Closed
@wangela wangela mentioned this issue Oct 13, 2023
Merged
4 tasks
@vladcioricagoogle
Copy link
Author

@kikoso after merging the PR for the location button is it possible to take care of this because you already have enough context on the subject and it should be pretty similar? Thanks!

@kikoso kikoso mentioned this issue Nov 13, 2023
Merged
4 tasks
@kikoso
Copy link
Collaborator

kikoso commented Nov 13, 2023

@vladcioricagoogle , this PR will fix this issue, if you want to take a look at:

#457

@vladcioricagoogle
Copy link
Author

@kikoso LGTM, thank you very much!

@kikoso
Copy link
Collaborator

kikoso commented Nov 15, 2023

@vladcioricagoogle , you are welcome! You can start using this now based on this approach, since it is a sample.

@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladcioricagoogle vladcioricagoogle

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: added custom zoom controls googlemaps/android-maps-compose
4 participants
@kikoso @wangela @googlemaps-bot @vladcioricagoogle