Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleMap composable uses modifier twice #438

Closed
ln-12 opened this issue Oct 20, 2023 · 4 comments
Closed

GoogleMap composable uses modifier twice #438

ln-12 opened this issue Oct 20, 2023 · 4 comments
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ln-12
Copy link
Contributor

ln-12 commented Oct 20, 2023

In #347, the myLocationButton parameter for the GoogleMap composable was introduced and a new Row child was added. The problem now is that this Row uses the same (passed in) modifier as the AndroidView. In my use case, I have to set a custom background color to the map to better integrate it into our design just before the map loads. With the modifier parameter being used twice, that is not possible, as the Row overlays the AndroidView with the same size and the provided background color.

Steps to reproduce

  1. Use the GoogleMap composable and provide a .background(Color.Black) modifier.
  2. The color overlays the map so that it is not visible anymore.

Code example

GoogleMap(
    modifier = Modifier
        .background(Color.Black)
        .fillMaxSize(),
) {
    // ...
}
@ln-12 ln-12 added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 20, 2023
@wangela
Copy link
Member

wangela commented Oct 20, 2023

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@ln-12 Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@kikoso
Copy link
Collaborator

kikoso commented Oct 20, 2023

@ln-12 , this will be fixed via this PR:

#428

@kikoso kikoso closed this as completed Oct 20, 2023
@wangela wangela reopened this Oct 20, 2023
@wangela
Copy link
Member

wangela commented Oct 20, 2023

This will be automatically closed when PR #428 is merged.

@kikoso
Copy link
Collaborator

kikoso commented Oct 27, 2023

Closing this one, since #428 is merged.

@kikoso kikoso closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants