Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADMINISTRATIVE_AREA_LEVEL_6 and ADMINISTRATIVE_AREA_LEVEL_7 is missing from AddressComponentType #807

Open
utsabn34 opened this issue Mar 1, 2022 · 4 comments · May be fixed by #932
Open

ADMINISTRATIVE_AREA_LEVEL_6 and ADMINISTRATIVE_AREA_LEVEL_7 is missing from AddressComponentType #807

utsabn34 opened this issue Mar 1, 2022 · 4 comments · May be fixed by #932
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@utsabn34
Copy link

utsabn34 commented Mar 1, 2022

Hi Team,
It looks like ADMINISTRATIVE_AREA_LEVEL_6 and ADMINISTRATIVE_AREA_LEVEL_7 is missing from AddressComponentType which is highly used for the Geocoding address component in country like Indonesia. This address component is also being returned by Google in Geocoding API. So please add this two Address Component Type in the /google-maps-services-java/blob/main/src/main/java/com/google/maps/model/AddressComponentType.java class.

Eg:
https://developers-dot-devsite-v2-prod.appspot.com/maps/documentation/utils/geocoder#q%3DJl%2520%2520RT.11/RW.7%252C%2520Duri%2520Utara%252C%2520Kec.%2520Jakarta%252011270%252C%2520Indonesia

image
@utsabn34 utsabn34 added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 1, 2022
@jpoehnelt
Copy link
Contributor

@utsabn34 Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

This is an automated message, feel free to ignore.

@arriolac arriolac added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 1, 2022
@arriolac
Copy link
Contributor

arriolac commented Mar 1, 2022 •
edited
Loading

Please feel free to submit a pull request for this.

@utsabn34
Copy link
Author

utsabn34 commented May 9, 2022

@arriolac @jpoehnelt Any update on this ticket?

@jacekgajek jacekgajek linked a pull request Nov 10, 2023 that will close this issue
Open
@jacekgajek
Copy link

jacekgajek commented Nov 10, 2023 •
edited
Loading

I've raised a PR, please take a look:
#932
I've just signed CLA. I don't know how to make my commit more "semantic" than it is, sorry.

jacekgajek pushed a commit to jacekgajek/google-maps-services-java that referenced this issue Nov 10, 2023
@jacekgajek-codibly
Fixes googlemaps#807: Add new administrative area levels in the Addre…
5b24deb 
…ss model

This commit introduces administrative area levels 6 and 7 to the Address model. This has been added to accommodate more granular geographic divisions that some countries may have. Corresponding changes are reflected in the EnumsTest as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#807: Add new administrative area levels in the Address model jacekgajek/google-maps-services-java
4 participants
@arriolac @jpoehnelt @utsabn34 @jacekgajek