Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The labelStyle parameter is not being applied #757

Open
wlius-support3 opened this issue Apr 26, 2023 · 2 comments
Open

The labelStyle parameter is not being applied #757

wlius-support3 opened this issue Apr 26, 2023 · 2 comments
Assignees
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wlius-support3
Copy link

It appears that the labelStyle parameter is not being applied.
According to the documentation, the labelStyle parameter is supposed to allow you to specify custom styles for the label. However, when I try to use this parameter, it does not seem to have any effect on the appearance of the label.
I have tried passing various values for the labelStyle parameter, but none of them seem to make a difference. The label text always appears with the default style, regardless of what I specify for labelStyle.
I believe this is a bug in the package, as the labelStyle parameter is documented as a valid option but does not appear to be working correctly. It would be great if this could be fixed so that users can take advantage of the full range of customization options available.

Steps to reproduce

  1. Use the googlemaps/js-markerwithlabel package to add a marker to a Google Map.
  2. Specify the labelStyle parameter with custom styles for the label.
  3. Observe that the label appears with the default style, ignoring the styles specified in labelStyle.

Code example

import { MarkerWithLabel } from '@googlemaps/markerwithlabel';

new MarkerWithLabel({
    position: new google.maps.LatLng(49.475, -123.84),
    clickable: true,
    draggable: true,
    map: map,
    labelContent: "foo", // can also be HTMLElement
    labelAnchor: new google.maps.Point(-21, 3),
    labelClass: "labels", // the CSS class for the label
    labelStyle: { opacity: 1.0, color: "red" }, // <- this seems to be ignored
})

Expected behavior:

The label should appear with the styles specified in the labelStyle parameter.

Actual behavior:

The label appears with the default style, ignoring the styles specified in labelStyle.

Affected version:

The issue appears to be present in the latest version (and seemingly all previous versions) of the package as of this writing (v2.0.21). I actually cannot find any reference in any of the code to labelStyle in the git history.

@wlius-support3 wlius-support3 added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 26, 2023
@wangela
Copy link
Member

wangela commented Apr 26, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@wlius-support3 Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@dasdawidt
Copy link

dasdawidt commented May 13, 2024

I worked around this by setting labelContent to a HTML string like so:

new MarkerWithLabel({
    labelContent: `<strong style="color: red">${text}</strong>`
})

But would greatly apprechiate if it would be fixed, since background and other styles do not get applied properly in this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants