Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type in google.maps.GeocoderRequest #77

Open
nbouvrette opened this issue Mar 19, 2023 · 1 comment
Open

Incorrect type in google.maps.GeocoderRequest #77

nbouvrette opened this issue Mar 19, 2023 · 1 comment
Assignees
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nbouvrette
Copy link

I'm not sure if this is the right place to fill this issue since I could not open issues on https://github.com/googlemaps/DefinitelyTyped

I've been writing wrappers on two common APIs, the autocomplete and the Geocoder.

I noticed the following type on autocomplete (google.maps.places.AutocompletionRequest) which looks like it maps to the API's request parameters.

I would presume that the Geocoder version (google.maps.GeocoderRequest) would have the same role but it contains a placeId which is not compatible with the place_id parameters from the Geocode API.

I might be misinterpreting the types and maybe they should not be used like this.

@nbouvrette nbouvrette added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 19, 2023
@wangela
Copy link
Member

wangela commented Mar 19, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@nbouvrette Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants