Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] <Adding support for Partitioned attribute for 3rd Party Cookie deprecation> #272

Closed
1 task done
kashishbehl opened this issue Apr 1, 2024 · 4 comments · Fixed by #273
Closed
1 task done

Comments

@kashishbehl
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem? Please describe.

Chrome will be disabling 3rd Party Cookie support by the end of June 2024. As a solution chrome has added support for creating cookies with independent partitioned state called CHIPS.
This will be achieved by adding Partitioned attribute in cookies to allow cookie to be partitioned to the website where it is set.

Describe the solution that you would like.

We need to add support for a new cookie attirbute named Partitioned.

Describe alternatives you have considered.

No response

Anything else?

No response

AlexVulaj pushed a commit that referenced this issue May 4, 2024
…rome 3rd party cookie phaseout (#273)

<!--
For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.

     For a timely review/response, please avoid force-pushing additional
     commits if your PR already received reviews or comments.

     Before submitting a Pull Request, please ensure that you have:
- 📖 Read the Contributing guide:
https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md
- 📖 Read the Code of Conduct:
https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md

     - Provide tests for your changes.
     - Use descriptive commit messages.
	 - Comment your code where appropriate.
	 - Squash your commits
     - Update any related documentation.

     - Add gorilla/pull-request-reviewers as a Reviewer
-->

## What type of PR is this? (check all applicable)

- [ ] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
- [ ] Go Version Update
- [ ] Dependency Update

## Description
The PR contains the change to add Partitioned attribute in the cookies.
As chrome will be deprecating support for 3rd Party cookies, we need to
add support for CHIPS to make cookies partitioned to the website.
## Related Tickets & Documents

<!--
For pull requests that relate or close an issue, please include them
below. We like to follow [Github's guidance on linking issues to pull
requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).

For example having the text: "closes #1234" would connect the current
pull
request to issue 1234.  And when we merge the pull request, Github will
automatically close the issue.
-->

- Related Issue #
- Closes #272

## Added/updated tests?

- [x] Yes
- [ ] No, and this is why: _please replace this line with details on why
tests
      have not been included_
- [ ] I need help with writing tests

## Run verifications and test

- [ ] `make verify` is passing
- [ ] `make test` is passing
@kramesh2005new
Copy link

Getting following issue while get this package and building because of this implementation

Screenshot from 2024-05-08 14-53-57

@broody
Copy link

broody commented May 23, 2024

Getting following issue while get this package and building because of this implementation

Screenshot from 2024-05-08 14-53-57

Running into the same issue.

Edit: Looks like it'll be available in go 1.23 golang/go#62490 (comment)

@jaitaiwan
Copy link
Member

Thanks for bringing this to our attention. I'll have to take a look at how to fix this.

@jaitaiwan
Copy link
Member

Support added in v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants