Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Insufficient Session Expiration #282

Closed
1 task done
ramvisa opened this issue Sep 11, 2024 · 1 comment
Closed
1 task done

[BUG] Insufficient Session Expiration #282

ramvisa opened this issue Sep 11, 2024 · 1 comment
Labels

Comments

@ramvisa
Copy link

ramvisa commented Sep 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

sonatype-2021-4899 The gorilla/sessions package is vulnerable due to Insufficient Session Expiration. The library allows for the creation of session cookies with the NewCookieStore() function in store.go. However, there is no mechanism available for invalidating user sessions once they have been created in this way. The documentation instructs users to set the MaxAge attribute of a cookie to -1 using the MaxAge() function in order to invalidate the session associated with it. However, this does not invalidate the users session on the server. A malicious user who is able to retrieve the value of a users' session cookie through a Cross-Site Scripting (XSS) attack, a Man-in-the-Middle (MitM) attack, or by some other means, will be able to use that session cookie to impersonate the user even after that user has logged out.

Expected Behavior

Invalidate the user session on the server

Steps To Reproduce

No response

Anything else?

No response

@ramvisa ramvisa added the bug label Sep 11, 2024
@jaitaiwan
Copy link
Member

Up to the implementer on how the close or not the session on the server. Next time use the correct security channel for reporting vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants