feat(notifier): retry mechanism on slack notif #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdh
reviewed
Mar 27, 2024
mabdh
reviewed
Mar 27, 2024
mabdh
reviewed
Mar 27, 2024
rahmatrhd
reviewed
Apr 1, 2024
rahmatrhd
reviewed
Apr 1, 2024
plugins/notifiers/client.go
Outdated
| @@ -19,7 +20,8 @@ type Client interface { | |||
| } | |||
|
|
|||
| const ( | |||
| ProviderTypeSlack = "slack" | |||
| ProviderTypeSlack = "slack" | |||
| DefaultTimeoutInSeconds = 10 | |||
There was a problem hiding this comment.
this also can be part of pkg/http
There was a problem hiding this comment.
Timeout is the part of the new HTTP client from Go package. Let's just remove the const and use the default from the http package (90 secs). But still this 10 secs should be set on config since 90 is too much for the timeout.
Co-authored-by: StewartJingga <[email protected]>
Co-authored-by: StewartJingga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.