Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery provider with only resource type table inserts 0 resources to db #73

Closed
rahmatrhd opened this issue Sep 16, 2023 · 1 comment · Fixed by #104
Closed

bigquery provider with only resource type table inserts 0 resources to db #73

rahmatrhd opened this issue Sep 16, 2023 · 1 comment · Fixed by #104
Labels
bug Something isn't working provider: bigquery

Comments

@rahmatrhd
Copy link
Member

Description

guardian/plugins/providers/bigquery/provider.go

Line 159 in 3bd8e74

dataset.Children = append(dataset.Children, table)

We add table resources as child resources of a dataset, if dataset resource type is not specified, table resources are not added into the imported resources.

To Reproduce

  1. Create bigquery provider with only one resource type: table
  2. Run fetch resources job
  3. Job done successfully but resources added is 0

Expected behavior
Should insert/upsert table resources to db
@rahmatrhd rahmatrhd added bug Something isn't working provider: bigquery labels Sep 16, 2023
@bsushmith
Copy link
Collaborator

tagging this - #12. since it would also be resolved, if the above is done.

@bsushmith bsushmith linked a pull request Oct 26, 2023 that will close this issue
fix(provider): bigquery provider with only resource type table insert… #104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working provider: bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(provider): bigquery provider with only resource type table insert… goto/guardian
2 participants
@rahmatrhd @bsushmith