Link list compatibility with [email protected]

[quoclieusecurityshift]

Feature Request

• I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
• I’ve read and agree to the Code of Conduct.
• I’ve searched for any related issues and avoided creating a duplicate issue.
• I've searched the community forums to check for related issues or feature requests

Is this feature request relating to an existing component? Please describe.

• Component name: link-list
• Component version: 3.0.8

Make the link-list component compatible with react-router-dom ver 5.1 and up - specifically with the new Link component. At the moment link-list only works with the Link component that is version 5.0.1 and below. Our project is looking to use some of the new react-router-dom features found in 5.1 but is currently stuck using 5.0.1 due to this issue.

Do you have a suggestion for a new component?

Remove/change the check for if linkComponent is a function. [email protected] Link component seems to be a context object.

// REMOVE THIS
 else if( typeof LinkComponent === 'function' ) {
	attributeOptions.to = link;
}

Ideally this would be changed in the header and footer components as well.

[gordongrace]

Really good suggestion, @quoclieusecurityshift . We've been able to reproduce this on the components you've mentioned. This appears to be a fairly easy fix to a foundational issue.

Thanks for taking the time to report the issue.

[qfz]

FYI @quoclieusecurityshift and I work in the same team and there's a PR (#891) for this issue. I submitted the PR right before I went on a week-long leave and forgot to let Quoc know.