-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Episode art uses too much space #131
Comments
Even with 4.11.2 which only shows episode art in the player/episode info page? |
Even with 4.11.2 which only shows episode art in the player/episode info page? Yes. |
Just to expand on the problems caused by storing episode art:
|
What podcast would that be?
We can't prevent this, except when they use the same URL in which case it also shouldn't happen.
Weird, doesn't happen by me. |
I just noticed, that it is downloading all episodeart beforehand. I have podcasts here with 230+ Episodes where each episode has its own art. I reset my storage and am now waiting for an opml import already for like 10 minutes. (episode art downloading shouldnt block the podcasts from being shown as refreshed probably) Maybe it would be good to do some more advanced handling of episode art. E.g. only loading the 20 newest, deleting old ones, etc. This would also mean, that we would need to download episodeart on demand if the user scrolls down the list. |
Why not download the art dynamically, only when it's details page is opened, or when it itself is downloaded? |
Hey, I just implemented dynamic download on a test build by me, it works fine. I have several questions:
Also I'm considering adding a page that shows space usage of a podcast and allows removal of all downloaded materials. |
I would say yes to both questions. |
Please let me know what you think of the new implementation in 4.12.0, I think this resolves it, no settings yet though. |
I tested 4.12.0 from openrepos on Jolla1 and while it's definitely an improvement, it's still more memory hungry than 4.10. This may be because of other features as well of course. Dynamically downloading episodes art is obviously better than downloading everything when refreshing feeds, but I would still prefer having a setting for episodes art where the options are
For Jolla1, probably only the last two would be usable. |
Could you please disable downloading episode art, or at least make it optional?
I have less than 40 feeds, and gpodder on Jolla1 often gets OOM-killed even when it's the only app running and just playing a random episode. If I try to access the Fresh episode list, it will instantly freeze and is eventually killed. Downloading episode art makes the feed updates take a lot longer and eat a lot of bandwidth.
Versions before 4.11 were working fine.
The text was updated successfully, but these errors were encountered: