GRAFANA_TOKEN env variable is not passed correctly

[jl2397]

When the Grafana class is initialized in grafana.py, there is only a check for the "url" field in the parameters. If the GRAFANA_TOKEN env variable is set, the token is never passed to the GrafanaApi client and therefore results in a GrafanaUnauthorizedError when making requests using grafana_client. A credential field needs to be added to the from_url call to populate the GRAFANA_TOKEN env variable.

[amotl]

Dear @julialau23. Thanks a stack for the report. May we ask if you would have the capacities to submit a patch?

[jl2397]

Hi Andreas, Sure I can do that. Can I get write access to the repo?

…

On Wed, Jul 3, 2024 at 1:17 PM Andreas Motl ***@***.***> wrote: Dear @julialau23 <https://github.com/julialau23>. Thanks a stack for the report. May we ask if you would have the capacities to submit a patch? — Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APHZBJWBEYZQLWD3G3LLIMDZKRL7HAVCNFSM6AAAAABJJTPFUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGE3DSNZSHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[amotl]

Hi @julialau23. Thanks a stack. You can easily fork the repository, and then submit a pull request, no?

[amotl]

Hi @julialau23. We just wanted to check if you have been able to come up with a solution for this you could share with the community?

[jl2397]

Hi @amotl, apologies for the delay. Pull request has been opened.

[amotl]

Thanks a stack for your contribution per GH-19. I've just merged the improvement with GH-20.

[amotl]

Your improvements have been released per grafana-import v0.3.0, now on PyPI.

[amotl]

I think it will be safe to close this issue. Please re-open otherwise.