Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support importing multiple dashboards from directory #27

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

vrymar
Copy link
Contributor

@vrymar vrymar commented Oct 16, 2024

About

We have the need to import all dashboards available in a provided directory.

References

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 40.54054% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@fbd5375). Learn more about missing BASE report.

Files with missing lines Patch % Lines
grafana_import/cli.py 40.54% 22 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   68.91%           
=======================================
  Files           ?        5           
  Lines           ?      444           
  Branches        ?        0           
=======================================
  Hits            ?      306           
  Misses          ?      138           
  Partials        ?        0           
Flag Coverage Δ
unittests 68.91% <40.54%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrymar
Copy link
Contributor Author

vrymar commented Oct 16, 2024

Rebased on upstream/main. Still tests fail

@amotl amotl force-pushed the feture-import-from-dir-support branch from 10be5d6 to 88b89bb Compare October 16, 2024 16:15
@amotl amotl changed the title Feture import from dir support Feature: Support importing multiple dashboards from directory Oct 16, 2024
@amotl
Copy link
Contributor

amotl commented Oct 16, 2024

Hi again. I've just fixed the software tests. Because messages are correctly going to Python's logger now (thanks!), a few of the test cases needed to be adjusted to compare output of Python's logger instead of introspecting stdout, effectively using pytest's caplog fixture now, instead of capsys.

@amotl amotl merged commit 2c99a25 into grafana-toolbox:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants