-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit invocation without configuration file, for promoting ad hoc operations #9
Conversation
91d4a0f
to
2cef059
Compare
0cb2462
to
a333ab6
Compare
The feature is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
Everything is fine for me.
You can merge if you are ready.
In this mode, the Grafana URL can optionally be defined using the environment variable `GRAFANA_URL`.
About
The idea of this patch is to make it possible to invoke
grafana-import
without needing to use a configuration file, in order to promote ad hoc use. We hope it will be received well.Usage
Instead of defining Grafana connectivity settings within the configuration file, the program now also supports defining it through the command line argument
--grafana_url
, and the environment variableGRAFANA_URL
, in the same way likegrafana-client
is doing it.Details
In this spirit, this feature expands into quite the opposite direction what the program was originally conceived for, using a configuration file which can store multiple Grafana connection profiles. We think the program can well be used for both use cases, so this patch relaxes the must-have constraint about having a configuration file.
Trivia
This is a stacked PR, based on GH-8. It can be reviewed independently, but please do not merge prematurely.
References