fix: annotation scraping - scrape_port_named_metrics and metrics.grafana.com/port #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes in modules/kubernetes/annotations/metrics.alloy
__tmp_scrape
is default set tofalse
, but the next step watches formetrics.grafana.com/scrape
to be blank ortrue
and then makes the value of__tmp_scrape
=true
. So__tmp_scrape
would never be blank. But the step that runs if the attributescrape_port_named_metrics
=true
only runs if__tmp_scrape
is true or blank. The point of that attribute is to scrape any port that contains the wordmetrics
in its name, regardless of themetrics.grafana.com/scrape
attribute, but it was not working that way since it could never be blank. We only want that step to not run ifmetrics.grafana.com/scrape
=false
, which it is now only set to__tmp_scrape
if the attribute is set to false, not just by default.metrics.grafana.com/port
to be set to override the__address__
port had an additional source label added to it when it was copied from grafana-agent-modules, but the regex was not adjusted to account for the additional label, so the step would never work.