Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to TerraformPluginSDK framework #107

Closed
patst opened this issue Mar 18, 2024 · 5 comments
Closed

Switch to TerraformPluginSDK framework #107

patst opened this issue Mar 18, 2024 · 5 comments

Comments

@patst
Copy link
Contributor

patst commented Mar 18, 2024

I have read the blob post about performance boost and resource usage decrease when using the new TerraformPluginSDK mode. (see upjet v1.1.0 release notes )

If I understand everything correct, it would make sense to use this in the Grafana Provider as well.

A template with the required steps could be the PullRequest for the Azure Provider
@julienduchesne
Copy link
Member

Sounds amazing. Probably fixes #87 as well

julienduchesne added a commit that referenced this issue Mar 18, 2024
@julienduchesne
Use new WithTerraformPluginSDKIncludeList mode
6fa15dd 
Issue: #107
This should be much faster. Testing it...
@julienduchesne julienduchesne mentioned this issue Mar 18, 2024
Merged
@julienduchesne
Copy link
Member

I will try to implement it this week!

julienduchesne added a commit that referenced this issue Mar 19, 2024
@julienduchesne
Use new WithTerraformPluginSDKIncludeList mode
536ac4e 
Issue: #107
This should be much faster. Testing it...
julienduchesne added a commit that referenced this issue Mar 20, 2024
@julienduchesne
Use new WithTerraformPluginSDKIncludeList mode (#113)
b418373 
* Use new `WithTerraformPluginSDKIncludeList` mode
Issue: #107
This should be much faster. Testing it...

* Update

* Add operation tracker store

* Remove setup

* oops

* progress

* Update init function
@julienduchesne
Copy link
Member

It's slightly faster 😆
image

Released in v0.13.0. Tested on our cluster, runs fine!

@patst
Copy link
Contributor Author

patst commented Mar 20, 2024

It's slightly faster 😆 image

Released in v0.13.0. Tested on our cluster, runs fine!

That is amazing!
Thanks for implementing it!

@julienduchesne julienduchesne mentioned this issue Mar 20, 2024
Closed
@julienduchesne
Copy link
Member

Thank you for pointing it out!

@Breee Breee mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patst @julienduchesne