Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tempo-distributed traceql queryFrontend missing traceql metrics configuration options #3323

Closed
ovidiubuligan opened this issue Sep 23, 2024 · 0 comments · Fixed by #3439
Closed

tempo-distributed traceql queryFrontend missing traceql metrics configuration options #3323

ovidiubuligan opened this issue Sep 23, 2024 · 0 comments · Fixed by #3439

Comments

@ovidiubuligan
Copy link
Contributor

ovidiubuligan commented Sep 23, 2024 •
edited
Loading

The following is the templating composition of config.yaml for the whole tempo-distributed from the values file :

  query_frontend:
    max_outstanding_per_tenant: {{ .Values.queryFrontend.config.max_outstanding_per_tenant }}
    max_retries: {{ .Values.queryFrontend.config.max_retries }}
    search:
      target_bytes_per_job: {{ .Values.queryFrontend.config.search.target_bytes_per_job }}
      concurrent_jobs: {{ .Values.queryFrontend.config.search.concurrent_jobs }}
    trace_by_id:
      query_shards: {{ .Values.queryFrontend.config.trace_by_id.query_shards }}

The traceql metrics options can be seen here : https://grafana.com/docs/tempo/latest/operations/traceql-metrics/#set-traceql-metrics-query-options
Setting traceql query options is not possible . Can the helm template be future ready with by modifying the above templated config with something like the pseudo helm :

  # values file
  queryFrontend:
    extraConfig : 
         metrics:
             concurrent_jobs: 42
          
  query_frontend:
    max_outstanding_per_tenant: {{ .Values.queryFrontend.config.max_outstanding_per_tenant }}
    max_retries: {{ .Values.queryFrontend.config.max_retries }}
    search:
      target_bytes_per_job: {{ .Values.queryFrontend.config.search.target_bytes_per_job }}
      concurrent_jobs: {{ .Values.queryFrontend.config.search.concurrent_jobs }}
    trace_by_id:
      query_shards: {{ .Values.queryFrontend.config.trace_by_id.query_shards }}
    {{ .Values.queryFrontend.extraConfig }}
@ovidiubuligan ovidiubuligan changed the title grafana-distributed traceql queryFrontend missing traceql metrics configuration options tempo-distributed traceql queryFrontend missing traceql metrics configuration options Sep 23, 2024
@faridtmammadov faridtmammadov mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tempo-distributed] add query frontend metrics config faridtmammadov/helm-charts
1 participant
@ovidiubuligan