`ConfigEditor` updates #72

aangelisc · 2023-09-07T12:55:35Z

For standardisation across Grafana we're updating datasource config editors to be more consistent. This is a part of https://github.com/grafana/oss-plugin-partnerships/issues/225.

This is a breaking change as the plugin now has a minimum Grafana dependency of 9.5.0

The config editor has been updated to replace InlineField with Field and the config editor has been refactored to use the new config editor structural components. There is also now individual validation on required fields. Node version has also been upgraded to 18.

Fixes grafana/oss-plugin-partnerships#254

- Replace legacy components - Update tests - Add version utils - Add grafana/experimental

adamyeats

👍 Looks good! I'd be keen to see if the semver package can be used instead of having our own code for this, it's so commonly used that it's probably already in our deps tree somewhere so we're probably OK just to depend on it ourselves.

src/utils/version.ts

.config/webpack/webpack.config.ts

src/components/Divider.tsx

.config/webpack/webpack.config.ts

src/editors/SentryConfigEditor.tsx

package.json

This reverts commit 2f90bf3.

github-actions · 2023-09-07T17:17:00Z

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:3215575afb38e055019baa33f90a648d0d094ff8pre

github-actions · 2023-09-07T17:56:34Z

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:569a391ea3cb29cb20b6dca4917d4f538e36aa48pre

github-actions · 2023-09-07T17:58:43Z

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:1138e710d3665314d9b9d5ab9e62ab97715c7475pre

github-actions · 2023-09-08T09:37:27Z

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:a170342e6d49a7ada7658ef7c777d0f38d4d8adbpre

aangelisc added 4 commits September 7, 2023 12:44

Update plugin config

482218f

Bump node version

e64310b

Bump ui package and min grafana version

efae33f

Update Config editor

79519c0

- Replace legacy components - Update tests - Add version utils - Add grafana/experimental

aangelisc added the effort/small label Sep 7, 2023

aangelisc self-assigned this Sep 7, 2023

aangelisc requested a review from a team as a code owner September 7, 2023 12:55

aangelisc requested review from asimpson, bossinc, adamyeats and alyssabull and removed request for a team September 7, 2023 12:55

Update workflows

6134f47