Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Buildscript by publishing to gradlePluginPortal #340

Open
codeconsole opened this issue Sep 23, 2024 · 7 comments
Open

Eliminate Buildscript by publishing to gradlePluginPortal #340

codeconsole opened this issue Sep 23, 2024 · 7 comments
Assignees

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Sep 23, 2024

if grails-gradle-plugin is published to gradlePluginPortal,

buildSrc/build.gradle
settings.gradle
and a buildscript { }

are no longer needed for Grails Apps.

Also remove need for

apply plugin:"org.grails.grails-web"
apply plugin:"org.grails.grails-gsp"

grails-gradle-plugin currently consists of

org.grails.grails-core
org.grails.grails-doc
org.grails.grails-gsp
org.grails.grails-plugin
org.grails.grails-profile
org.grails.grails-web extends org.grails.grails-plugin
org.grails.internal.grails-plugin-publish
org.grails.internal.grails-profile-publish

org.grails.grails-web should automatically be applied if org.grails:grails-web-url-mappings is present
org.grails.grails-gsp should automatically be applied if org.grails:grails-gsp is present

@codeconsole codeconsole converted this from a draft issue Sep 23, 2024
@codeconsole codeconsole changed the title Eliminate Buildscript by publishing Gradle Plugins to gradlePluginPortal Eliminate Buildscript by publishing to gradlePluginPortal Sep 23, 2024
@davydotcom
Copy link
Contributor

I suggest moving the contents of grails-web into the grails-core gradle plugin and simplifying some of the structure. A lot of plugins were split instead of just using config to enable/disable available tasks a plugin provides

@codeconsole
Copy link
Contributor Author

codeconsole commented Oct 24, 2024

@davydotcom sure, it makes sense to merge grails-web and grails-core. Perhaps grails-gsp should remain separate and we start just by publishing grails-gsp and grails-core plugins?

The hope is in the future I will get around to making grails-gsp independent of grails

@codeconsole
Copy link
Contributor Author

@davydotcom isn't a simple solution to just merge grails-web into grails-gradle-plugin then make org.grails.grails-plugin and org.grails.grails-gsp subprojects and just publish them? Later the other plugins could be make subprojects as well with a common core if needed

@codeconsole
Copy link
Contributor Author

actually, we can just publish grails-gradle-plugin and move org.grails.grails-gsp into the grails-gsp project

@jamesfredley
Copy link
Contributor

somewhat related to #351

@matrei
Copy link
Contributor

matrei commented Nov 14, 2024

Related: #54

@jdaugherty
Copy link

Somewhat related to #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

5 participants