Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate add and offset functions #2669

Open
Felixoid opened this issue Jan 20, 2021 · 4 comments
Open

Consolidate add and offset functions #2669

Felixoid opened this issue Jan 20, 2021 · 4 comments

Comments

@Felixoid
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As I see and discuss with @dzhdanov, add and offset are pretty much the same functions with different descriptions and small implementation details.

Describe the solution you'd like
One function should be an alias to another with only one implementation

Describe alternatives you've considered
The alternative would be to leave it as it is, but now it doesn't look good, even from the documentation side: add vs offset

@stale
Copy link

stale bot commented Mar 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 21, 2021
@deniszh deniszh added pinned and removed stale labels Mar 21, 2021
@deniszh deniszh removed the pinned label Oct 26, 2022
@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 31, 2022
@Felixoid
Copy link
Contributor Author

Felixoid commented Jan 2, 2023

Is it still the case?

@stale stale bot removed the stale label Jan 2, 2023
@deniszh
Copy link
Member

deniszh commented Jan 2, 2023

I think so. Pinned.

@deniszh deniszh added the pinned label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants