Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed button colors should match #41

Open
esokullu opened this issue Aug 24, 2019 · 5 comments
Open

Feed button colors should match #41

esokullu opened this issue Aug 24, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@esokullu
Copy link
Contributor

Screen Shot 2019-08-24 at 7 56 39 AM

also there's an alignment issue too.

This problem is in graphjs repo. If you make the changes in plain html (using Chrome Editor) and send them to me, I can commit them to that repo.

@esokullu esokullu added the bug Something isn't working label Aug 24, 2019
@esokullu
Copy link
Contributor Author

Use https://gr.ps/oha3/home to improve.

@esokullu
Copy link
Contributor Author

We also need a bookmark icon there:
https://iconmonstr.com/bookmark-1-svg/

so I'll need the implementation of that too.

@YaGen
Copy link
Collaborator

YaGen commented Aug 26, 2019

As I see https://gr.ps/oha3/home load graphjs-theme.less from https://graphjs.com/graphjs-theme.less, but there is an old version of it, some of styles are missing. Needs to be updated with latest dist from graphjs repo.

<div class="graphjs-bookmark-indicator"> <a class={'graphjs-icon ' + (userId ? 'graphjs-authorized' : 'graphjs-unauthorized')} data-id={activity.id}> <svg viewBox="0 0 24 24"><path d="M18 24l-6-5.269-6 5.269v-24h12v24z"/></svg> </a> </div>
This code should be inserted on line 117 in feed-item.tag
and .@{prefix}-bookmark-indicator { .@{prefix}-icon { display: block; float: left; position: relative; width: 2.5em; height: 2.5em; text-align: center; .border-radius(inherit); svg { display: inline-block; position: relative; width: 100%; height: 50%; margin: 25% 0; padding-top: 3px; path { // ThemeOption: fill: desaturate(@text-color-normal, 65%); } } } } in feed-item.less

Tell me when backend for bookmark will be ready and I will be able to add it to corresponding .tag

@esokullu
Copy link
Contributor Author

Just saw this, will do.

@esokullu
Copy link
Contributor Author

esokullu commented Sep 8, 2019

I did the graphjs-theme.less
but what about the color difference in share icon?
I need that first before the bookmark icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants