Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2022-12] Add a note to CoerceArgumentValues linking back to IsVariableUsageAllowed note #1336

Closed
benjie opened this issue Jul 8, 2023 · 2 comments
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Jul 8, 2023

Relates to graphql/graphql-spec#1002

Validation note: http://spec.graphql.org/draft/#sec-All-Variable-Usages-Are-Allowed.Allowing-Optional-Variables-When-Default-Values-Exist

Relevant algorithm: http://spec.graphql.org/draft/#CoerceArgumentValues() (specifically 5.j.iii.1)

Timestamped video link: https://youtu.be/nkPn-F_UBJo?list=PLP1igyLx8foH30_sDnEZnxV_8pYW3SDtb&t=3378


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie self-assigned this Jul 8, 2023
@benjie benjie added the stale label Oct 11, 2023
@benjie
Copy link
Member Author

benjie commented Nov 9, 2023

I realised after this call that my original issue was indeed legitimate and we'd gotten a little confused on the call and thought I was talking about an argument being a variable, when what I was talking about was a list item being a variable.

I've addressed this by raising a clarifying PR here: graphql/graphql-spec#1058

@benjie benjie added Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. and removed stale labels Nov 9, 2023
@benjie
Copy link
Member Author

benjie commented Dec 7, 2023

PR raised to RFC1; closing

@benjie benjie closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Development

No branches or pull requests

1 participant