Adding Istanbul to tests for coverage reports #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagoar
commented
Nov 20, 2020
| @@ -33,6 +33,7 @@ | |||
| "start": "node lib/server", | |||
| "watch": "babel scripts/watch.js | node", | |||
| "test": "npm run lint && npm run check && npm run test:only", | |||
| "test:coverage": "nyc --report-dir coverage --reporter=lcov --reporter=text mocha $npm_package_options_mocha", | |||
There was a problem hiding this comment.
I've used the directory coverage so we keep things similar when moving to jest (jest by default creates reports in coverage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides reporting the current mocha tests.
in order to land #185 we need to get the coverage report that mocha doesn't generate.
hopefully, this will be temporary till I finish the jest migration (given that jest already comes with Istanbul)
I've also removed several other coverage tools that were in the project:
coverallsandisparta.Considerations
If we decide to land #190 this PR will be closed automatically