-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
different Bytes
lengths on ==
can still give True
#48
Comments
@robinheghan any objection to the fix linked in the description? This is affecting some cli work I'm doing so I'd be happy to test the fix and submit a PR if you think it looks good. |
@blaix No objection to the fix. |
blaix
added a commit
to blaix/gren-lang-core
that referenced
this issue
Mar 21, 2024
Should fix gren-lang#48 Using suggested fix from https://github.com/elm/core/pull/1092/files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In contrast to json
Value
s, the documentation don't explicitly discourage calling==
onBytes
, neither inelm/bytes#15
The reason for this could again be, that, like for json values, the equal-check function only compares properties of the first argument. Here's one fix https://github.com/elm/core/pull/1092/files
The text was updated successfully, but these errors were encountered: