Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using namespace * #65

Open
lucasterra opened this issue Jan 20, 2020 · 0 comments · May be fixed by #68 or grepdemos/thrift-parser#8
Open

Support using namespace * #65

lucasterra opened this issue Jan 20, 2020 · 0 comments · May be fixed by #68 or grepdemos/thrift-parser#8

Comments

@lucasterra
Copy link

The Thrift spec allows you to use namespace *, which means that the IDL applies to all target languages: https://thrift.apache.org/docs/idl#namespace

The parser doesn't currently allow for that, because it treats NamespaceScope as an Identifier, which only allows for alpha numeric characters, dots, and underlines: [a-zA-Z0-9\._].

The solution would be to create a NamespaceScope type, which allows for Identifier | *. This would be a breaking change, though. Because it would changes the AST output.

I'm happy to work on a PR for that, if you are ok with the breaking change, and you don't have any other alternative solution to fix this issue.

@lucasterra lucasterra linked a pull request Jan 27, 2020 that will close this issue
@lizard-boy lizard-boy linked a pull request Oct 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant