From 06e7214542bd8f2231f747b1a2f80ddce42eb7a4 Mon Sep 17 00:00:00 2001 From: Shounak Dey Date: Wed, 30 Oct 2024 21:12:44 +0530 Subject: [PATCH] Add removal of NamedTemporaryFile and correct the docstring Modify the positioning of replacement text of `arti_shot`s Signed-off-by: Shounak Dey --- gi_loadouts/face/scan/file.py | 2 ++ gi_loadouts/face/scan/rule.py | 8 +------- test/face/scan/test_scan.py | 18 +++++------------- 3 files changed, 8 insertions(+), 20 deletions(-) diff --git a/gi_loadouts/face/scan/file.py b/gi_loadouts/face/scan/file.py index 29bd25fd..d132d392 100644 --- a/gi_loadouts/face/scan/file.py +++ b/gi_loadouts/face/scan/file.py @@ -12,6 +12,7 @@ def __init__(self): def load_mask_from_file(self, path: str) -> Tuple[QPixmap, ImageFile]: """ Handle file operations involved in loading data from the storage device + Backend :return: Image that is intended to be read from """ @@ -25,6 +26,7 @@ def load_mask_from_file(self, path: str) -> Tuple[QPixmap, ImageFile]: def load_screenshot_with_picker(self, prnt, head: str) -> Tuple[bool, QPixmap, ImageFile]: """ Handle file operations involved in loading data from the storage device + Frontend :return: Image that is intended to be read from """ diff --git a/gi_loadouts/face/scan/rule.py b/gi_loadouts/face/scan/rule.py index 61568c19..6f1d2c52 100644 --- a/gi_loadouts/face/scan/rule.py +++ b/gi_loadouts/face/scan/rule.py @@ -435,10 +435,4 @@ def wipe_snapshot(self) -> None: :return: """ - self.arti_shot.setText(""" - -

YOUR ARTIFACT SCREENSHOT WILL SHOW UP HERE

-

IF YOU HAVE AN ARTIFACT SCREENSHOT IN YOUR CLIPBOARD, SIMPLY PRESS CTRL + V TO PASTE IT HERE

-

DRAG AND DROP WORKS AS WELL

- - """) + self.arti_shot.setText("

YOUR ARTIFACT SCREENSHOT WILL SHOW UP HERE

IF YOU HAVE AN ARTIFACT SCREENSHOT IN YOUR CLIPBOARD, SIMPLY PRESS CTRL + V TO PASTE IT HERE

DRAG AND DROP WORKS AS WELL

") diff --git a/test/face/scan/test_scan.py b/test/face/scan/test_scan.py index e7ec1e42..076bc06b 100644 --- a/test/face/scan/test_scan.py +++ b/test/face/scan/test_scan.py @@ -249,6 +249,11 @@ def test_scan_arti_scan_fail(scantest: ScanDialog, qtbot: QtBot, mocker: MockerF assert "Please select an accurate screenshot." in scantest.dialog.text() assert scantest.dialog.isVisible() + """ + Cleanup the temporary files from temp directory + """ + remove(savefile.name) + @pytest.mark.parametrize( "_", @@ -703,14 +708,6 @@ def test_scan_arti_scan_fail_ic(scantest: ScanDialog, _: None) -> None: :return: """ - """ - Create a temporary file filled with random data to simulate a failure when trying to open an - image using PIL.Image.open(). - """ - savefile = NamedTemporaryFile(prefix="gi-loadouts-", suffix=".exe", delete=False, mode="wb") - savefile.write(randbytes(512*1024)) - savefile.close() - """ Perform the action of loading the artifact information """ @@ -727,11 +724,6 @@ def test_scan_arti_scan_fail_ic(scantest: ScanDialog, _: None) -> None: assert "Please select an accurate screenshot." in scantest.dialog.text() assert scantest.dialog.isVisible() - """ - Cleanup the temporary files from temp directory - """ - remove(savefile.name) - @pytest.mark.parametrize( "_",