Fixing AbstractMethodError

growthbook · Nov 22, 2024 · a8f844c · a8f844c
1 parent 3e2d6d2
commit a8f844c
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 17 deletions.
diff --git a/Core/src/commonMain/kotlin/com/sdk/growthbook/network/NetworkDispatcher.kt b/Core/src/commonMain/kotlin/com/sdk/growthbook/network/NetworkDispatcher.kt
@@ -25,6 +25,4 @@ interface NetworkDispatcher {
         onSuccess: (String) -> Unit,
         onError: (Throwable) -> Unit
     )
-
-    fun setLoggingEnabled(enabled: Boolean)
 }
diff --git a/GrowthBook/src/commonMain/kotlin/com/sdk/growthbook/GBSDKBuilder.kt b/GrowthBook/src/commonMain/kotlin/com/sdk/growthbook/GBSDKBuilder.kt
@@ -156,9 +156,7 @@ class GBSDKBuilder(
         return GrowthBookSDK(
             gbContext,
             refreshHandler,
-            networkDispatcher.apply {
-                setLoggingEnabled(enableLogging)
-            }
+            networkDispatcher,
         )
     }
 }
diff --git a/GrowthBook/src/jvmTest/kotlin/com/sdk/growthbook/tests/MockNetworkClient.kt b/GrowthBook/src/jvmTest/kotlin/com/sdk/growthbook/tests/MockNetworkClient.kt
@@ -49,8 +49,6 @@ class MockNetworkClient(
             onError(ex)
         }
     }
-
-    override fun setLoggingEnabled(enabled: Boolean) = Unit
 }
 
 class MockResponse {

diff --git a/NetworkDispatcherKtor/build.gradle.kts b/NetworkDispatcherKtor/build.gradle.kts
@@ -9,7 +9,7 @@ plugins {
 }
 
 group = "io.growthbook.sdk"
-version = "1.0.2"
+version = "1.0.3"
 
 kotlin {
     android {

diff --git a/...ispatcherKtor/src/commonMain/kotlin/com/sdk/growthbook/network/GBNetworkDispatcherKtor.kt b/...ispatcherKtor/src/commonMain/kotlin/com/sdk/growthbook/network/GBNetworkDispatcherKtor.kt
@@ -49,12 +49,11 @@ class GBNetworkDispatcherKtor(
     /**
      * Ktor http client instance for sending request
      */
-    private val client: HttpClient = createDefaultHttpClient()
+    private val client: HttpClient = createDefaultHttpClient(),
 
+    private var enableLogging: Boolean = false,
 ) : NetworkDispatcher {
 
-    private var enableLogging = false
-
     /**
      * Function that execute API Call to fetch features
      */
@@ -161,7 +160,7 @@ class GBNetworkDispatcherKtor(
         }
     }
 
-    override fun setLoggingEnabled(enabled: Boolean) {
+    fun setLoggingEnabled(enabled: Boolean) {
         enableLogging = enabled
     }
 

diff --git a/NetworkDispatcherOkHttp/build.gradle.kts b/NetworkDispatcherOkHttp/build.gradle.kts
@@ -5,7 +5,7 @@ plugins {
 }
 
 group = "io.growthbook.sdk"
-version = "1.0.1"
+version = "1.0.2"
 
 kotlin {
     android {

diff --git a/...tcherOkHttp/src/commonMain/kotlin/com/sdk/growthbook/network/GBNetworkDispatcherOkHttp.kt b/...tcherOkHttp/src/commonMain/kotlin/com/sdk/growthbook/network/GBNetworkDispatcherOkHttp.kt
@@ -36,12 +36,11 @@ class GBNetworkDispatcherOkHttp(
     /**
      * Ktor http client instance for sending request
      */
-    private val client: OkHttpClient = OkHttpClient()
+    private val client: OkHttpClient = OkHttpClient(),
 
+    private var enableLogging: Boolean = false,
 ) : NetworkDispatcher {
 
-    private var enableLogging = false
-
     /**
      * Function that execute API Call to fetch features
      */
@@ -152,7 +151,7 @@ class GBNetworkDispatcherOkHttp(
         }
     }
 
-    override fun setLoggingEnabled(enabled: Boolean) {
+    fun setLoggingEnabled(enabled: Boolean) {
         enableLogging = enabled
     }
 }