Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted features are not parsed, after latest version fix #72

Closed
sbliatsios opened this issue Aug 19, 2024 · 2 comments
Closed

Encrypted features are not parsed, after latest version fix #72

sbliatsios opened this issue Aug 19, 2024 · 2 comments
Assignees

Comments

@sbliatsios
Copy link

After the fix in latest version 1.0.59 71, with the removal of !features.isEmpty the encrypted features are not parsed, because there is an empty array of features. We need to check if encrypted features also exist.

Also there is a decoding error in FeaturesViewModel in prepareFeatureData when decoding the FeaturesDataModel. The issue is that the savedGroups property is declared as String? but in fact is a dictionary.

@Kevin-Chant
Copy link

@vazarkevych could you take a look here (and let me know if you need any help w/ the savedGroups part)? I'd jump in but I haven't started learning Swift yet 😅

@vazarkevych
Copy link
Collaborator

Hi, @sbliatsios. Thank you for providing the detailed information. We found an issue, fixed it, and will provide a pull request for it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants