Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch version constraints tag does not support paging in tags list #46

Open
yorinasub17 opened this issue Dec 7, 2018 · 3 comments
Open
Labels
bug Something isn't working

Comments

@yorinasub17
Copy link
Contributor

If you are referencing a sufficiently old release tag in a version constraints tag, fetch will fail.

Example:

fetch --repo 'https://github.com/gruntwork-io/module-ecs' --tag '~>v0.3.2' foo

fails with:

ERROR: Error occurred while computing latest tag that satisfies version contraint expression: -1 - Tag does not exist
@josh-padnick
Copy link
Contributor

Interesting, this definitely sounds like a bug. All the automated tests on this tool assume a small number of releases, so we didn't explicitly test against large numbers of releases. Perhaps when we fix this, for the failing test first, we can find an open source repo that has a large number of releases and triggers this bug.

@brikis98 brikis98 added bug Something isn't working help wanted labels Dec 7, 2018
@brikis98
Copy link
Member

brikis98 commented Dec 7, 2018

Could this be a pagination issue? i.e., if there are lots of tags, we are only fetching the first page of results?

@yorinasub17
Copy link
Contributor Author

Yes. Sorry I should have mentioned that in the description, but added that to the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants