Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patcher use cases page: Terraform patch should be code text, not image #594

Closed
infraredgirl opened this issue Aug 17, 2021 · 1 comment · Fixed by #607
Closed

Patcher use cases page: Terraform patch should be code text, not image #594

infraredgirl opened this issue Aug 17, 2021 · 1 comment · Fixed by #607
Assignees
@brikis98
Milestone
patcher-v2

Comments

@infraredgirl
Copy link
Contributor

Follow up to #546/#583.

Currently the "tabbed divs" only support having images in all tabs, or code in all tabs, but not a mix. We'll need to add support for mixed tabs and replace the terraform patch image with code text.
@infraredgirl infraredgirl added this to the patcher-v2 milestone Aug 17, 2021
@brikis98 brikis98 self-assigned this Aug 19, 2021
@brikis98
Copy link
Member

I ended up taking this on in #607

@brikis98 brikis98 mentioned this issue Aug 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brikis98 brikis98

Labels
None yet
Projects
None yet
Milestone
patcher-v2
Development

Successfully merging a pull request may close this issue.

Update use case page images gruntwork-io/gruntwork-io.github.io
2 participants
@brikis98 @infraredgirl