Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make featured headlines come before featured img #622

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Make featured headlines come before featured img #622

merged 4 commits into from
Aug 25, 2021

Conversation

zackproser
Copy link
Contributor

Fixes #616

@netlify
Copy link

netlify bot commented Aug 23, 2021

✔️ Deploy Preview for keen-clarke-470db9 ready!

🔨 Explore the source changes: 62039cc

🔍 Inspect the deploy log: https://app.netlify.com/sites/keen-clarke-470db9/deploys/612544544415c60008a5a307

😎 Browse the preview: https://deploy-preview-622--keen-clarke-470db9.netlify.app

Copy link
Contributor

@bwhaley bwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the How it Works page, the third item in the Maintainer workflow (Create a patch file) is oriented backward, e.g. the code is on the left, the text is on the right, but it should be the opposite.

@zackproser
Copy link
Contributor Author

On the How it Works page, the third item in the Maintainer workflow (Create a patch file) is oriented backward, e.g. the code is on the left, the text is on the right, but it should be the opposite.

Yeah, that's a long-standing issue with all of our how-it-works pages. I'll have to wrestle with the columns + offsets on that tomorrow.

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a crack at this Zack!

I'm really not trying to nitpick for the sake of nitpicking, but I have a gut feeling that the large images are making it harder to skim the page.

Here's an idea to try:

First, for the pull request image (the one below "You review and merge"), here's a smaller screenshot that I think will cleanly fit the zig-zag and still captures all the same content:

Screen Shot 2021-08-24 at 2 06 39 PM

(I created it by shrinking my browser window down and using chrome dev tools to remove / shrink stuff that wasn't necessary)

Now, the "Use the UI" and "Use the CLI" tabs are harder. Perhaps what we can do there is to create a thumbnail of each that fits the zig-zag UI (410x310) and overlay a "play" button on top of each (since something is overlayed on the thumbnail anyway, it doesn't have to be super crisp). When the user clicks the play button, we add a tiny bit of JS code to replace the image with the full-size, sharp, readable gif, which starts playing. That way, while skimming, you have the normal zig-zag flow, but when you want to see details, you can still do so, and you'll be paying full attention to it after clicking (rather than seeing a .gif part way through playing while scrolling).

WDYT?

@zackproser
Copy link
Contributor Author

Thanks for taking a crack at this Zack!

I'm really not trying to nitpick for the sake of nitpicking, but I have a gut feeling that the large images are making it harder to skim the page.

Here's an idea to try:

First, for the pull request image (the one below "You review and merge"), here's a smaller screenshot that I think will cleanly fit the zig-zag and still captures all the same content:

Screen Shot 2021-08-24 at 2 06 39 PM

(I created it by shrinking my browser window down and using chrome dev tools to remove / shrink stuff that wasn't necessary)

Now, the "Use the UI" and "Use the CLI" tabs are harder. Perhaps what we can do there is to create a thumbnail of each that fits the zig-zag UI (410x310) and overlay a "play" button on top of each (since something is overlayed on the thumbnail anyway, it doesn't have to be super crisp). When the user clicks the play button, we add a tiny bit of JS code to replace the image with the full-size, sharp, readable gif, which starts playing. That way, while skimming, you have the normal zig-zag flow, but when you want to see details, you can still do so, and you'll be paying full attention to it after clicking (rather than seeing a .gif part way through playing while scrolling).

WDYT?

Makes sense - I will take a crack at implementing that.

@zackproser
Copy link
Contributor Author

Implemented in a5a1618

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Zack!

@brikis98
Copy link
Member

Merging now.

@brikis98 brikis98 merged commit f51e2aa into master Aug 25, 2021
@brikis98 brikis98 deleted the zack-616 branch August 25, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wide images in Patcher landing page break the flow a bit
3 participants