Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorize & Install Grunty (GitHub App) image on Patcher landing page is slightly blurry #629

Open
brikis98 opened this issue Aug 25, 2021 · 4 comments
Open

Authorize & Install Grunty (GitHub App) image on Patcher landing page is slightly blurry #629

brikis98 opened this issue Aug 25, 2021 · 4 comments
Assignees
@marinalimeira
Milestone
patcher-v3

Comments

@brikis98
Copy link
Member

As reported by a user: https://twitter.com/jayanth_s_iyer/status/1430499849770729476
@brikis98 brikis98 added this to the patcher-v3 milestone Aug 25, 2021
@marinalimeira marinalimeira self-assigned this Aug 25, 2021
@marinalimeira
Copy link
Contributor

I can work on this one!

@marinalimeira
Copy link
Contributor

Screen Shot 2021-08-25 at 16 45 05

@ina-stoyanova @brikis98 some feedback before opening the PR?

@ina-stoyanova
Copy link
Contributor

looks good to me! Looks very sharp! 🦈

@brikis98
Copy link
Member Author

The image looks sharp here, but the key question is how it'll look at the rendered size on the Patcher page. From Chrome webtools, it looks like the image is rendered at 377x482 on the Patcher home page... So we probably want the screenshot to be that exact size.

@marinalimeira marinalimeira mentioned this issue Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marinalimeira marinalimeira

Labels
None yet
Projects
None yet
Milestone
patcher-v3
Development

Successfully merging a pull request may close this issue.

New screenshot for GH app gruntwork-io/gruntwork-io.github.io
4 participants
@brikis98 @infraredgirl @marinalimeira @ina-stoyanova