Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error right at the beginning #35

Closed
vblanche21 opened this issue Jun 6, 2023 · 4 comments
Closed

error right at the beginning #35

vblanche21 opened this issue Jun 6, 2023 · 4 comments

Comments

@vblanche21
Copy link

Hello,
I'm getting this error:
image

What should I do?

Many thanks,
Vincent

@gszep
Copy link
Owner

gszep commented Jun 6, 2023

Hi there! Thank you so much for submitting this bug report 😁 I am keen to get this fixed for you so that FlowAtlas may be useful to you! Would you be able to attach a small sample of the file that FlowAtlas is failing to load?

@vblanche21
Copy link
Author

vblanche21 commented Jun 7, 2023

Hi there! Thank you so much for submitting this bug report 😁 I am keen to get this fixed for you so that FlowAtlas may be useful to you! Would you be able to attach a small sample of the file that FlowAtlas is failing to load?

Hi, many thanks, Here is a link to a flowjo wsp and 2 FSC files. appreciate your help.

https://github.com/vblanche21/flowatlas

@gszep gszep reopened this Nov 12, 2023
@gszep
Copy link
Owner

gszep commented Nov 12, 2023

Hi @vblanche21 ! Apologies for the delayed progress on this. I've investigated the issue:

  • The string patterns that I was using to identify channels were too relaxed and the code was accidentally parsing the $PANELNAME keyword as a channel.
  • the channel names (property "S") were not unique; --A and --H were assigned to two different channels

I am updating FlowWorkspace.jl and FlowAtlas.jl to deal with the above issues. For now, an error is raised to ask the user to rename duplicate channel names. gszep/FlowWorkspace.jl@6bedae1

@gszep gszep closed this as completed Nov 12, 2023
@gszep
Copy link
Owner

gszep commented Nov 12, 2023

updating FlowAtlas.jl to use FlowWorkspace v0.1.17 and de-duplicating --A and --H for FL5 and FL8 will allow you to use FlowAtlas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants