Add VerticalSpacing property to Collections
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab-gnm
requested review from
aoifemcl15,
waisingyiu,
lindseydew and
falloutfox
and removed request for
a team
ab-gnm
changed the title
VerticalSpacing proeprty to CollectionsVerticalSpacing property to Collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
VerticalSpacingwith valuesRegularandCompact.content_vertical_spacingtoCollectionmodel.The intent of this PR is that MAPI will guide the apps on which vertical spacing to use for rows & cards within a collection.
Regularfor most collections (represented as 24px in-app)Compact(represented as 16px in-app)Have we considered potential risks?