[Fairground] Add palette colours for the pill on media cards #138
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoifemcl15
approved these changes
Dec 12, 2024
|
@waisingyiu has published a preview version of this PR with release workflow run #123, based on commit f4b62ad: 1.0.42-PREVIEW.fairgroundadd-palette-colours-for-media-pill.2024-12-12T1408.f4b62adf Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fairground/add-palette-colours-for-media-pill branch, or use the GitHub CLI command: gh workflow run release.yml --ref fairground/add-palette-colours-for-media-pill Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
lindseydew
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We are building new media cards as part of the homepage redesign project. On the new design, there is a pill component on the card to show, for example, the number of images for a gallery or the duration of the video.
The pull request adds new properties
media_pill_backgroundandmeida_pill_foregroundtoPaletteto provide the native apps with the colours to use on the pill component.