Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Pull requests welcome? #504

Open
rhedin opened this issue Nov 21, 2016 · 1 comment
Open

Pull requests welcome? #504

rhedin opened this issue Nov 21, 2016 · 1 comment

Comments

@rhedin
Copy link

rhedin commented Nov 21, 2016

Hello. I am starting to work with this package. It looks nice. Thanks!

I wonder whether pull requests are welcome. I see some things I would like to change. For example, ctrl-z is hard-coded as the undo character. In some situations, people might want it to be something else, especially non-English-speakers.

But the maintainers of the package might not feel that such changes are worth pulling into the main branch, or they might even feel that such changes make the code worse. Shall I submit pull requests? Or shall I fork it?

       Regards, Rick
@rrees
Copy link
Contributor

rrees commented Feb 3, 2017

In this case it seems sensible to pull the current behaviour into the default configuration behaviour and then allow it to be over-ridden if you want it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants