p1: Add Gradle binary compatibility plugin #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Style.contentColour` provides text and icon colour. Icon colour can be optionally overridden in slot. - `Style.badgeColour` provides badge colour if not Unspecified, and not overridden in slot. - items before & after text are now provided using `Indicator` sealed class. This allows correctly sizing and spacing them - Fixed spacing based on icon/image presence - Added previews for all variants
…t, instead of additional `isVisible` property
# Conflicts: # android/build-logic/convention/src/main/kotlin/com/theguardian/convention/DetektPlugin.kt
# Conflicts: # android/source/build.gradle.kts
ab-gnm
changed the title
1. Extracted spacing logic to a separate function to make it slightly easier to understand 2. Removed `SourceChip` overload that allowed setting both before and after indicators 3. Made implementation function internal and renamed to `SourceChipInternal`
p4: Add & update documentation
p2: Detekt configuration clean up
p3: Add `SourceChip`s components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Gradle binary compatibility plugin, and the
.apifile generated from it.Binary compatibility is a signal whether a new version of the library contains breaking changes. I intend to use the changes to
.apifile to automatically update library version numbers (in a future PR).Testing notes/instructions:
The api file isn't used anywhere yet, so just confirm the checks pass.
Checklist