-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade to Play 2.9, fix Scala Steward
This upgrade to Play 2.9 was prompted by guardian/scala-steward-public-repos#67 which means that all projects that want to have Scala Steward updates (like this one) need to be able to _build_ under Java 21 (even if the projects are still _running_ in production on Java 11). Building under Java 21 requires a recent version of sbt, and that leads to a version bump for `scala-xml` that gives version-compatibility errors: ``` [error] * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over {1.2.0, 1.1.1} [error] +- org.scala-lang:scala-compiler:2.12.18 (depends on 2.1.0) [error] +- com.typesafe.sbt:sbt-native-packager:1.5.2 (scalaVersion=2.12, sbtVersion=1.0) (depends on 1.1.1) [error] +- com.typesafe.play:twirl-api_2.12:1.5.1 (depends on 1.2.0) ``` ...the nicest way to fix these errors is to upgrade to Play 2.9 or above, so here we are! https://github.com/guardian/pan-domain-authentication didn't get Play 2.9 artifacts until relatively recently, so upgrading the Panda version was also necessary. See also: * guardian/maintaining-scala-projects#1
- Loading branch information
Showing
3 changed files
with
8 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
sbt.version=1.7.1 | ||
sbt.version=1.9.9 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters