Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd handling of ID generation for LanguageToolCore rules on creation #484

Open
jonathonherbert opened this issue Nov 6, 2024 · 0 comments

Comments

@jonathonherbert
Copy link
Contributor

jonathonherbert commented Nov 6, 2024

For rules of type languageToolCore, we add a CHANGE_ME value to externalId when the rule is first written.

But it's perfectly possible to write some value to a rule when you first create it, while the rule is not a languageToolCore rule, and then switch the rule type to languageToolCore, exposing the UUID that was created on the initial write:

Yuk. We should use a separate property to store the languageToolCore ID used to refer to the LanguageTool rule, not externalId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant