Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EnableServiceLinks #91

Closed
gecube opened this issue Jun 6, 2024 · 1 comment · Fixed by #118
Closed

Remove EnableServiceLinks #91

gecube opened this issue Jun 6, 2024 · 1 comment · Fixed by #118

Comments

@gecube
Copy link

gecube commented Jun 6, 2024

Hello!

By default the enableServiceLinks is true.

kubectl explain deployment.spec.template.spec.enableServiceLinks
GROUP:      apps
KIND:       Deployment
VERSION:    v1

FIELD: enableServiceLinks <boolean>

DESCRIPTION:
    EnableServiceLinks indicates whether information about services should be
    injected into pod's environment variables, matching the syntax of Docker
    links. Optional: Defaults to true.

It means that there is a bunch of unused and unnecessary ENVs inside of containers. I am kindly asking to remove it. Or to make configurable.
@guerzon guerzon mentioned this issue Sep 7, 2024
Merged
@guerzon
Copy link
Owner

guerzon commented Sep 7, 2024

Thanks for raising this @gecube. I have merged #118 that added support to disable service links. You could add this to your values file:

enableServiceLinks: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make enableServiceLinks configurable guerzon/vaultwarden
2 participants
@gecube @guerzon